Example model configs for telecommute_status model#30
Merged
jpn-- merged 19 commits intoActivitySim:mainfrom Sep 26, 2025
Merged
Example model configs for telecommute_status model#30jpn-- merged 19 commits intoActivitySim:mainfrom
telecommute_status model#30jpn-- merged 19 commits intoActivitySim:mainfrom
Conversation
dhensle
approved these changes
Sep 1, 2025
Member
Author
|
The test is failing when validating the result against the target pipeline because we split the telecommute frequency category 2_3_days_week into two categories, 2_days_week and 3_days_week, as requested. As a result, half of the person records that previously had 2_3_days_week now have 2_days_week, and the other half have 3_days_week. I can update the target pipeline if that's ok. @jpn-- |
Member
Author
|
@jpn--, this PR is ready to be merged. Additionally, I fixed the CI workflow - it was testing against the latest release instead of the 'main' branch of ActivitySim. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yueshuaing This PR implements example model configs developed as part of the ActivitySim Phase 9 work. The code changes that pair with this PR is in ActivitySim/activitysim#935
telecommute_statusmodeltelecommute_statusmodel beforecdap(Note: This is different from the final explicit telecommute model design that was developed in subsequent Phase 9B telecommute design efforts.)[x] Made mandatory pattern unavailable for worker who is telecommuting on simulation day inUpdate: The result ofcdapconfigtelecommute_statusmodel is not used in any downstream models.2_3_days_weekinto two categories,2_days_weekand3_days_weektelecommute_fredequency == 2_3_days_weekwithtelecommute_fredequency == 2_days_week | telecommute_fredequency == 3_days_weekin downstream model UECs